CRM-13760 "Geocoding failed. Message from Google: OVER_QUERY_LIMIT" should not be fatal

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.3.8
    • Fix Version/s: 4.4.2
    • Component/s: None
    • Labels:
      None

      Description

      Geocoding is a nice feature, but the policies of google are very unclear. When this error occures it should not stop essential parts of the CRM. (Like people signing up for events, merging etc etc). It should only give a warning to admin.

      I have now had 2 times where a live site stopped working properly due to this problem, should not happen.

        Attachments

          Activity

          [CRM-13760] "Geocoding failed. Message from Google: OVER_QUERY_LIMIT" should not be fatal
          Donald A. Lobo added a comment -

          i agree on this there are multiple ways to hit this error and i think we need to respond differently in each case:

          a. for public pages, we ignore the error but log it / let admin know

          b. for non-public pages, we can let user know via a status message, but not abort

          c. for batch geocoding, we abort the process - since its unlikely that future requests will be geocoded

          hans - want to work on a patch for this?

          Donald A. Lobo added a comment -

          hans: there is this PR: https://github.com/civicrm/civicrm-core/pull/1991

          can u please QA the issue

          thanx

            People

            • Assignee:
              Donald A. Lobo
              Reporter:
              Hans Idink

              Dates

              • Created:
                Updated:
                Resolved: