CRM-13839 Support edits to line item amounts for upcoming recurring contributions

    Details

    • Type: Improvement
    • Status: Won't Do
    • Priority: Major
    • Resolution: Won't Do
    • Affects Version/s: 4.4.2
    • Fix Version/s: Unscheduled
    • Component/s: CiviContribute
    • Labels:
      None
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      Developer Doc
    • Funding Source:
      Needs Funding

      Description

      Implement an interface similar to cancel recurring contribution to allow payment processor plugins/extensions to indicate their ability to handle edits to upcoming recurring contributions.

      When a contribution_recur is created, currently line items are created for the first contribution. Instead, create them to point to the contribution_recur record itself. When a payment processor IPN callback occurs, change from creating the new contribution by copying the most recent one and its line items to copying the line items and total amount from the contribution_recur record, and as much other info as possible as well (if there are fields that are only present in contribution and not contribution_recur then use them). Ideally, reuse the code for this callback to create the first contribution as well.

      Implement a UI to be determined in concert with upcoming changes to Event line item editing (issue to be created) to allow the line items of the upcoming recurring contribution to be edited.

      Call a new payment processor method to modify an existing recurring donation. Ensure that this method is implemented in the current version of the Moneris payment processor, and also for the RBC direct debit system implemented for United Church. Change those payment processors so they advertise that they are able to edit line items.

      Upgrade:

      For each existing contribution_recur record which has upcoming recurring contributions (ie end_date>now() and next_sched_contribution_date>now()), create line items that point to the contribution_recur record by copying the line items pointing to the most recent contribution record in the series.

        Attachments

          Issue Links

            Activity

            [CRM-13839] Support edits to line item amounts for upcoming recurring contributions
            Pradeep Nayak added a comment - - edited

            .

            Pradeep Nayak added a comment -

            Sorry, Updated wrong issue

            Eileen McNaughton added a comment -

            Just looking at this

            For each existing contribution_recur record which has upcoming recurring contributions (ie end_date>now() and next_sched_contribution_date>now()), create line items that point to the contribution_recur record by copying the line items pointing to the most recent contribution record in the series.

            I wonder if the most robust way wouldn't actually to create an is_template contribution for each recurring contribution. The downside is that you would need to add filters to a bunch of reports and searches to exclude it. But, it does seem like a more robust way of recording what you want the next contribution to look like.

            Coleman Watts added a comment -

            Pradeep Nayak - this issue is marked as "Priority Critical" - will you have a PR ready by the Sept 23 alpha1 release? If it's not that important, then please downgrade the priority.

            Tamar Meir added a comment -

            Hi all,

            Arrived at this ticket from the reference made in https://issues.civicrm.org/jira/browse/CRM-16272 - this is a frequently requested feature from our clients as well, just want to make sure that when you mention copying as much information as possible, including information that is only in civicrm_contribution but not civicrm_contribution_recur, that things such as financial_type, non-deductible amount, is Gift Aid and is GST (a.k.a. custom data) are also copied over.

            Not sure if any work has been done on this since last year?

            Thanks,
            Tamar

            Eileen McNaughton added a comment -

            No progress The thinking is to record line items for the contribution recur template but nothing has happened

            Eileen McNaughton added a comment -

            closing this in favour of gitlab https://lab.civicrm.org/dev/financial/issues/6

              People

              • Assignee:
                Joe Murray
                Reporter:
                Joe Murray

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Time Spent - 1 day, 1 hour Remaining Estimate - 7 hours
                  7h
                  Logged:
                  Time Spent - 1 day, 1 hour Remaining Estimate - 7 hours
                  1d 1h