Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-13983

DataTables/media/css/demo_table_jui.css included on every page

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.4.3
    • Fix Version/s: 4.5
    • Component/s: None
    • Labels:
      None

      Description

      CiviCRM includes a CSS file (plugins/jquery/DataTables/media/css/demo_table_jui.css) which introduces style definitions with common selectors (.top, .bottom) and very visible rules (border: 1px solid white). This can cause CiviCRM to negatively affect otherwise functional site designs which use the same selectors.

      http://drupal.demo.civicrm.org/sites/drupal.demo.civicrm.org/modules/civicrm/packages/jquery/plugins/DataTables/media/css/demo_table_jui.css

      The name of the file (demo_*) suggests that it was not intended for general use and was perhaps included in CiviCRM unintentionally.

      Unfortunately the history in Git doesn't show the reasons for this file's inclusion in https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/common/jquery.files.tpl#L47

      The simple workaround is to override the common selectors with default behaviours (body .top

      { border-width: 0 ; }

      ).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                colemanw Coleman Watts
                Reporter:
                xurizaemon Chris Burgess
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: