Details
-
Type:
Improvement
-
Status: Done/Fixed
-
Priority:
Trivial
-
Resolution: Cannot Reproduce
-
Affects Version/s: 4.2.10
-
Fix Version/s: 4.4.4
-
Component/s: Core CiviCRM, Usability
-
Labels:None
Description
With mapping of contacts the organisation that I am part of has found some issues where browsers my block the map showing when a user goes to map contacts or click on the map icon for an address. This is mainly due to the fact that the map renders in http and we have all civi urls in https so browsers don't show the unsecured content.
The probable solution is to change the url in line 35 of google.tpl from // to $_SERVER['SERVER_PROTOCOL']. This would mean that civi would load the map based on what the server protocol is.
Attachments
Activity
I use Chrome mostly, this is the page source, I have also attached the source of the page which shows for some reason it is loading it in HTTP. I have reports from others in the organisation which have the same issue, not sure which browsers they use. Also i just tried in firefox and it calls into http. I tried testing on demo and it worked fine
Using $_SERVER['SERVER_PROTOCOL'] may cause problems for anyone who offloads SSL processing to a load balancer. It's safest to assume that the correct protocol cannot be determined from the request.
It's likely also that some parts of the site may be http and others https, and that that may be configured in the web server rather than the PHP app, so it's not safe to assume the correct protocol can be determined from the PHP app's configuration.
I think the best solution is to use [Scheme relative urls](http://www.w3.org/TR/url/#resolve-a-string-as-a-scheme-relative-url-0) (and it sounds like people expected that?). The generated source should look like src="//maps.google.com/..." whereas in the source image Seamus provided, the http protocol is explicit as src="http://maps.google.com". IS that the actual source,or a representation of the DOM?
I think the code has // but for some reason it is out putting as HTTP rather than HTTPS
Seamus
can you check the html on the demo site. I suspect this is a site specific issue and u'll need to check for custom templates etc.
what browser r u using? Most browser will supply the right protocol when one is not supplied, hence using // works quite nicely