Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.4.2
-
Fix Version/s: 4.5
-
Component/s: Drupal Integration Modules
-
Labels:None
Description
Drupal views 3 contextual filter on YYYY/MM/DD for custom data field of type datetime no longer works.
Worked in 4.3.5, broken after I upgraded to 4.4.2.
The setting of the field type (datetime) and offset (0) when calling function views_date_sql_extract() was removed sometime after version 4.3.5. Without setting those drupal views 3 uses its default field type of 'int' and an offset based on your timezone. This results in a SQL query which will return no results for the specified YYYY/MM/DD.
Here is an example from the file views_handler_argument_civicrm_day.inc
This is the current code from 4.4.2 which results in a sql query which returns no results:
$this->formula = views_date_sql_extract('DAY', "**table**.$this->real_field");
This is the same code line from 4.3.5 which works:
$this->formula = views_date_sql_extract('DAY', "**table**.$this->real_field",'datetime',0);
Calls to views_date_sql_extract() are found in the following files.
views_handler_argument_civicrm_day.inc
views_handler_argument_civicrm_month.inc
views_handler_argument_civicrm_week.inc
views_handler_argument_civicrm_year.inc
Attachments
Activity
Where can I find the source and commit messages? I can provide a patch but I don't know why this was changed and the patch may need more than just reverting the change that was made since this change may have been made to fix some other problem.
I wont get a chance to take a look until the weekend, let me know if you've already done it Glenn.
I'm not entirely sure if my pull request went through right, so attached a patch as well.
I reviewed the patch.
The last argument to the views_date_sql_extract function call of '0' is required because the default for that argument is adding to the query an offset in seconds based on your timezone. That is only needed if an int timestamp is used. So for a 'datetime' type that argument must be 0.
OK, I was under the impression that was optional. If you feel this is done, can you create another pull request for the core team?
Glenn, were you able to submit that pull request or submit your updated patch?
Thanks, Chris
Submitted pull request.
This issue is closed but there is still an open PR. Should the issue be re-opened of the PR closed?
Chris (or Glenn)
If you can take a look at this and submit a PR, we can get this into a 4.4 release