Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-14199

Incorrect Math in Import routines

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.4.3, 4.4.4
    • Fix Version/s: 4.5
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      When importing, maximum file size is reported and set at 1 MB. Forum post is:
      http://forum.civicrm.org/index.php/topic,31240.0.html

      In the file: civicrm/CRM/Import/DataSource/CSV.php
      The following formula in incorrect:
      $uploadSize = round(($uploadFileSize / (1024 * 1024)), 2);

      The formula should be:
      $uploadSize = round(($uploadFileSize / (1024 * 8)), 2);

      This is an apparent miscalculation that has been carried into multiple files. (There may be more, but these are the ones I found.):

      civicrm/CRM/Member/Import/Form/DataSource.php
      civicrm/CRM/Activity/Import/Form/DataSource.php
      civicrm/CRM/Contribute/Import/Form/DataSource.php
      civicrm/CRM/Event/Import/Form/DataSource.php

      Also, the FIXME line that is just above this seems to be looking at the problem backwards. It appears that if the limit is lower than 8MB, then it sets the limit to 8MB. Not sure that would work with php.ini settings.

        Attachments

          Activity

            People

            • Assignee:
              rohan1990 Rohan Ramesh Katkar
              Reporter:
              gharris G H
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 10 minutes
                10m
                Remaining:
                Remaining Estimate - 10 minutes
                10m
                Logged:
                Time Spent - Not Specified
                Not Specified