Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.4.0
-
Fix Version/s: 4.5
-
Component/s: None
-
Labels:None
-
Sprint:Sprint 1
Description
The formNavigate.js does not work reliably with the following:
- forms with ajax-loaded content
- popup forms
- tabbed forms
- multiple forms on the same page
It also doesn't do a good job of tracking changes and often gives false-positive warnings.
Steps to fix;
- Migrate tpl include to a form class variable
- Update core form renderer to add variable to markup
- Add function to CRM.utils (Common.js) to detect form changes
- Add global crmLoad event listener to store initial state of form elements
- Add global onBeforeUnload handler to check for unsaved changes
reference: http://dustinmartin.net/monitoring-a-form-for-changes-with-jquery/
Attachments
Issue Links
- supplements
-
-
- Done/Fixed
-
Activity
Generally this is working well. The false positives seem to be fixed in both pop-up and non-pop-up forms.
There's one behavior that I think is confusing and not ideal:
- Go to contact summary for some contact
- Action button > Register for Event
- Fill in a few fields, then close the pop-up w/ the 'x' on top right of window
You get the nice alert "Unsaved Changes" with "Restore" link.
- You decide you don't want to restore, so click the 'x' on that alert
- Now you click another menu item
You get the 'Are you sure - Page is asking you to confirm ...' jScript confirm pop-up. THIS IS CONFUSING, since I no longer have the unsaved form visible, and can't access it in any way.
-
-
-
- AND, if I do the same steps, but with 'Add Membership' action, I do not get the confusing jScript confirm. So something is happening differently in the Participant form ?? *****
-
-
Fixed the above-mentioned issue. Seems to be working reliably now.
pull request: https://github.com/civicrm/civicrm-core/pull/3068
This fully replaced jquery.FormNavigate.js
added a CRM_Core_Form variable (unsavedChangesWarn) to turn this functionality on/off
when true - buildForm will add an html attribute to all forms, "data-warn-changes'
Also checks CRM_Core_Action and TRUE by default for ADD and UPDATE
Form elements are processed and initial values are stored on each item in the data-attribute, 'crm-initial-value'. (See common.js)
For when disabling in the Form.php sub-class is not feasible, one can remove the form attribute. E.g. the disable for when forms are submitted:
{ // CRM-14353 - disable changes warn when submitting the form $(this).removeAttr('data-warn-changes'); }.on('submit', function(e)
)
Ajax forms implement the change-check in a cancelAction() in crm.ajax.js
Edge-case for dateDisplay widget in:
templates/CRM/common/jcalendar.tpl