Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.5
-
Fix Version/s: 4.5
-
Component/s: CiviContribute
-
Labels:None
-
Documentation Required?:None
Description
-
-
- This is a regression from 4.4
================
If a contribution is created from a price set that includes a membership fee, when the contribution is viewed the membership line_item is not displayed. This is related to the change in how line_item.entity_table and entity_id is stored for membership fees. We used to populate them with the contribution table / data for membership fees. Now we use civicrm_membership and membership.id in the entity columns and link to the contribution in the new line_item.contribution_id table.
- This is a regression from 4.4
-
To recreate the problem:
- create a price set w/ a membership field and an additional field for a t-shirt (for example)
- link the price set to online contribution page (you can use id=2)
- use the online contribution page to get a membership + t-shirt
- view the contribution record
The Contribution Amount table only contains the 'contribution' line item. The total is correct, but the membership fee line item is missing. See attached screenshots.
Attachments
Activity
I'm proposing this PR as an alternative:
https://github.com/civicrm/civicrm-core/pull/3526
It adds ORDER BY so results are consistent in the view, and also adds another line to the whereClause to handle viewing contributions for price-set based event registrations (which previously were not showing the line item listing).
However, given that this function (CRM_Price_BAO_LineItem::getLineItems) is called in lots of places, can you review my additions in case you think it might break some other use cases.
Thanks Dave for the additional change, it works. Although I grepped 'CRM_Price_BAO_LineItem::getLineItems' usage and tested all those possibilities - it is ready merge.
I believe the changes related to this issue has resulted into regression http://forum.civicrm.org/index.php/topic,33481.0.html . The issue persist on participant's view page only and it has something to do with
Line 146 + OR (li.contribution_id = %2.id AND li.entity_table = 'civicrm_participant'))
which eventually contributes wrong entries for getLineitem().
Dave I believe that it's not a correct approach to fetch line item currently on the basis of OR condition(s) at left join(LJ) which results in erroneous data as reported in forum. As per the changes made in https://issues.civicrm.org/jira/browse/CRM-14197 it confess, mainly on entity table to retrieve line item. So I think its better to revert the changes (i.e. remove OR condition form LJ) and call the fn on entity basis and in that way data can be placed at rightful position. Am I right on this?
(Discussed https://issues.civicrm.org/jira/browse/CRM-14197 changes with Pradeep)
Thanks,
Monish
Monish - Agreed. Go ahead and revert that commit. It sounds like you and Pradeep have come up with the correct way to fix the regression originally reported in this issue and ensure that line items are displayed for contributions created from a price set that includes a membership fee.
Submitted the PR https://github.com/civicrm/civicrm-core/pull/3727 also check its impact on all other spot where getLineItems() is being called.
T
Looks good - tested quick config and price set based event reg and memberships.
Submitted the PR https://github.com/civicrm/civicrm-core/pull/3522