Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.4.6
-
Fix Version/s: 4.5
-
Component/s: CiviContribute, CiviMember
-
Labels:None
-
Documentation Required?:None
Description
The bug occurs in the following circumstances:
1. one contact has two recurring payment plans
2. either both plans are "in progress" -or- one is "failed" and the other "in progress".
3. recurring payment plans both related to a currently yearly membership
You may be asking yourself, how did we get here? Well different memberships have different prices, or sometimes prices go up. Civi creates a new recurring plan for the new price. Fair enough. BUT CANCEL THE OLD PLAN and that's where the trouble starts.
In either case, if you choose "Cancel" on the older plan, it actually cancels the NEWER plan erroneously. See attached for examples.
Attachments
Activity
Monish: is there an api call that would work? Is "setvalue" action the problem (should it be changed to create)? Or is it something else?
Coleman: Yes the setvalue action is the reason
CRM.api3(info.entity, 'setvalue',
,
{success: successMsg}).done(refresh);
As there is no such field 'is_active' for contribution_recur table so eventually it throws a API Error saying that "error_message" : "Param 'field' (is_active) is invalid. must be an existing field''. And there is no api which can be used to cancel a recurring contribution also the task is irreversible, I mean you cannot revert/enable a cancelled recurring contribution.
But the best thing to do will be to write a api for cancel recurring contribution and to use that instead in genuine way like to add dynamic entity-action say cancel_recur intead of setvalue action. And I am half way towards the implementation.
Submitted the PR https://github.com/civicrm/civicrm-core/pull/3806
Also removed CRM_Contribute_BAO_ContributionRecur::setIsActive as it is not used/required anywhere else unlike in 4.4 and assured my changes.
Coleman can you please verify my changes.
It was a good idea to parameterize action, but then you need to update the inline-edit code to actually respect that setting!
Here's the update to do so:
https://github.com/civicrm/civicrm-core/pull/3808
Also changed the button labels on the confirmation since choosing to "cancel" a "cancel" action is weirdly confusing.
Unfortunately prior to above issue we cannot cancel a recurring contribution in 4.5 because eventually it calls setValue api for contribution_recur entity and tries to set is_active 0 as per workflow of common/enableDisableApi.tpl. So on click 'Cancel' it gives this error http://snag.gy/ZWw7O.jpg . Also replicated in sandbox.