Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-15234

Sample responsive design templates need {literal} tags around <script> block to prevent munging when CIVICRM_MAIL_SMARTY enabled

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.4.6
    • Fix Version/s: 4.5.1
    • Component/s: CiviMail
    • Labels:
      None
    • Documentation Required?:
      None

      Description

      This was reported by Marisa Porter due to unexpected changes in the output sent to mail clients (for our newsletter). Quite a few lines of markup are now being dropped - resulting in the newsletter not being properly viewable on iPhones and other non-desktop devices. The change occurred somewhere between v4.4.4 and 4.4.6.

      Attached files show the contents of the <script> </script> tag as output in May Newsletter vs. September Newsletter. Input was identical - but CIVICRM_MAIL_SMARTY was enabled on the site in between.

      SOLUTION: add

      {literal}

      ...

      {/literal}

      smarty tags inside the <script> ... </script> block in the sample templates. This will prevent problems if CIVICRM_MAIL_SMARTY is enabled AND our testing shows that these tags are ignored in the markup if they aren't stripped out (i.e. if CIVICRM_MAIL_SMARTY is NOT enabled).

        Attachments

        1. StyleTag_4.4.4or5.html
          4 kB
          David Greenberg
        2. StyleTag_4.4.6.html
          2 kB
          David Greenberg

          Activity

            People

            • Assignee:
              dgg David Greenberg
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: