CRM-15258 recurring msg template poor grammar

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.4.6
          • Fix Version/s: 4.5
          • Component/s: None
          • Labels:
            None
          • Documentation Required?:
            None

            Description

            contribution_recurring_edit_html renders as
            "Recurring contribution is for $ 1.00, every 1(s) month"

            (not months)

              Attachments

                Issue Links

                supplements

                Bug - A problem which impairs or prevents the functions of the product. CRM-15257 recurring msg template states number of installments - even when unlimited

                • Trivial - Cosmetic problem like misspelt words or misaligned text.
                • Done/Fixed

                  Activity

                  [CRM-15258] recurring msg template poor grammar
                  Eileen McNaughton added a comment -

                  block we are using in contribution_recurring_edit_html.tpl

                  <p>

                  {ts 1=$amount}

                  Recurring contribution is for %1,

                  {/ts} {strip}
                  2=$recur_frequency_interval 3=$recur_frequency_unit
                  {if $recur_frequency_interval == 1}
                  {ts 1=$recur_frequency_unit}every %1{/ts} {else}

                  {ts 1=$recur_frequency_interval 2=$recur_frequency_unit}

                  every %1 %2s

                  {/ts}
                  {/if}
                  {if $installments}{ts 1=$installments} for %1 installments.{/ts}

                  {/if} {/strip}

                  .
                  </p>

                  Eileen McNaughton added a comment -

                  & in the cancelled template

                  <p>

                  {ts 1=$amount}

                  Your recurring contribution of %1,

                  {/ts}{strip}
                  {if $recur_frequency_interval > 1}
                  {ts 3=$recur_frequency_unit}
                  every %3
                  {/ts} {else} {ts 2=$recur_frequency_interval 3=$recur_frequency_unit}

                  every %2 %3

                  {/ts}
                  {/if}
                  {ts}has been cancelled as requested.{/ts}

                  {/strip}

                  </p>

                  David Greenberg added a comment -

                  https://github.com/civicrm/civicrm-core/pull/4107
                  Eileen - can you take a quick look. I don't know of any easy way to spit out those notifications w/o credentials.

                  David Greenberg added a comment -

                  Can you or someone on your team please QA / test this upgrade and ideally test the recurring emails.

                  https://github.com/civicrm/civicrm-core/pull/4107

                    People

                    • Assignee:
                      Yashodha Chaku
                      Reporter:
                      Eileen McNaughton

                      Dates

                      • Created:
                        Updated:
                        Resolved: