Details
-
Type: Bug
-
Status: Done/Fixed
-
Priority: Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.4.6
-
Fix Version/s: 4.5.1
-
Component/s: None
-
Labels:None
-
Documentation Required?:Developer Doc
Description
Currently we pass parameters to the doDirectPayment method which presumably have a use case. They refer to contributionType. I think we should start passing the same params with the financialType naming convention as well & aim to remove contributionType in a couple of releases
eg.
// add some financial type details to the params list
// if folks need to use it
$paymentParams['contributionType_name'] = $form->_params['contributionType_name'] = $contributionType->name;
//CRM-11456
$paymentParams['contributionType_accounting_code'] = $form->_params['contributionType_accounting_code'] = CRM_Financial_BAO_FinancialAccount::getAccountingCode($contributionTypeId);
$paymentParams['contributionPageID'] = $form->_params['contributionPageID'] = $form->_values['id'];
Also set
$paymentParams['financialType_name'] = $paymentParams['contributionType_name'] ;