CRM-15341 Pop-up dialog obscured by Drupal shortcut bar

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.5
          • Fix Version/s: 4.5.1
          • Component/s: Core CiviCRM
          • Labels:
            None
          • Documentation Required?:
            None

            Description

            I found this problem in CiviCampaign, but it likely exists anywhere you have an option list long enough to fill the screen.

            When I select "New Survey", next to the "Activity Type" field is the new button to pop up editing of activity types (is there a name for this?).

            When I press the button, the pop-up that appears is longer than my screen, so it expands to just under the menu bar - but ignores the Drupal shortcut bar, which I assume is in core (this is my dev site, where CiviCRM and Devel are my only contrib modules). This makes it impossible to close the pop-up (see screenshot).

            I realize it may be impossible to fix all possible variations of this problem, but if there's a way to ensure that the pop-up is sized such that the "close" button is always visible, that'd be a great usability improvement.

              Attachments

                Activity

                [CRM-15341] Pop-up dialog obscured by Drupal shortcut bar
                Coleman Watts added a comment -

                We can't really stop the CMS from sticking extra stuff on the screen that gets in the way, but just to nitpick your use of the word "impossible"

                • You could press esc to close the dialog
                • You could hide the drupal shortcut bar
                • You could submit the form or click cancel and that will close the dialog (not applicable to this situation since the page is not a form, but most popups do have submit and cancel buttons)

                What to do about the drupal shortcut bar? I'm not sure... IMO it's a nuisance anyway and we're all better off without it. But I guess someone out there might disagree...

                Coleman Watts added a comment -

                The developer in me wants to say "won't fix" because this is all Drupal's fault (their css creates an incompatibility between the d7 toolbar and jQuery UI).
                But from a UX perspective, I want users to have a positive experience with CiviCRM even if they choose to use the toolbar.
                So here's a fix: https://github.com/civicrm/civicrm-core/pull/4210

                  People

                  • Assignee:
                    Coleman Watts
                    Reporter:
                    Jon K Goldberg

                    Dates

                    • Created:
                      Updated:
                      Resolved: