Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-15353

Two code quality issues in CRM_Price_BAO_PriceSet.php

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.5
    • Fix Version/s: 4.6
    • Component/s: CiviContribute
    • Labels:
      None
    • Documentation Required?:
      None

      Description

      While working on CRM_Price_BAO_PriceSet my IDE reports two possible issues that look like they could cause bugs:

      1) Line 678:
      (part of static function initSet(&$form, $id, $entityTable = 'civicrm_event', $validOnly = FALSE, $priceSetId = NULL) )

      if ($form->_action & CRM_Core_Action::UPDATE) {
      Error: "_action Member has protected access"

      2) Line 1078:
      (part of static function setPriceSets)

      CRM_Core_BAO_Discount::del($this->id,'civicrm' . $entityName);
      Error: "$this is not accessible in static context"

        Attachments

          Activity

            People

            • Assignee:
              kurund Kurund Jalmi
              Reporter:
              lola_slade Lola Slade
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: