Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-15433

Billing info and payment options blocks not hidden for $0 events with price sets when decimal delimiter is NOT a dot

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.5
    • Fix Version/s: 4.5.3
    • Component/s: None
    • Labels:
      None
    • Documentation Required?:
      None

      Description

      The conditional which hides the billing and payment info blocks in Register.tpl 'skipPaymentMethod' is hard-coded to match on the string 0.00. This fails if the the decimal delimiter is changed to a comma or some other character.

      if ((cj('#pricevalue').text() == symbol + " 0.00") && flag)

      — Original post ----
      I just went to test on demo if the fixes from CRM-14882 had been committed to events in 4.5 (since some of the code was added to Main.tpl rather than Calculate.tpl I thought I'd check) and found that the $0 boxes are not disappearing on the current demo.

      I attached a screen shot - note that the currency appears to be set to a european style.

      This could be something 'in progress' or out-of-date version - but I couldn't get it to remove the billing block
      If you check before it is reset here is where I configured it
      http://d45.demo.civicrm.org/civicrm/event/register?reset=1&id=3

      This is the 4.4 patch we are trialling on this - the issue is not exactly the same in 4.4 - but the fix possibly is - in that the point is to use the code from Main.tpl & move it into Calculate.tpl so it applies to events as well. There could be a gotcha in that calculate.tpl is not included in non-priceset cases - but I think the code only applies to price sets. (would be nice to make price sets easier to configure from within an event / contribution page as that is the main blocker to deprecating the non-price-set pricing)

      https://github.com/fuzionnz/civicrm-core/commit/81b954146825727fb35fcf61597882b4e6a46dd3

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dgg David Greenberg
                Reporter:
                eileen Eileen McNaughton
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: