CRM-15821 Provide option to notify Personal Campaign Page "Owner" when someone donates via their page

PR link: https://github.com/civicrm/civicrm-core/pull/4966

Generally looking good so I merged the PR. QA bugs / exceptions below.
===============

• Configure PCP (Configure Online Contribution Page - PCP tab):

• BUG: Owner Notification inline help - missing text. I think the radio button labels are sufficient so just remove the help icon.

• Radio button breaks aren’t readable - button is on separate line from label (Let’s do 1 item per line)

• Remove ‘Save and Next’ button from PCP tab (since it’s the last tab) - if easy.

• PCP "Owner" Configuration

• BUG: The new “Notify me” checkbox field is SOMETIMES MISSING in the initial workflow (setting up a new PCP - Step 2) : civicrm/contribute/campaign?_qf_Campaign_display=true

On a new contribution page I created with pcp_block.owner_notify_id = 1 …. that field is only showing up when I go back to Edit the PCP. And at that point it’s not checked even though default is checked (probably because the PCP was initially saved with the field hidden/not present). HOWEVER, on sample contribution page id=1 which also has pcp_block.owner_notify_id = 1 - the field is showing as expected in Setup Step 2. Not sure what’s causing this. Please try creating a new contribution page and see if you get the same issue.

• Owner Notification Email

• BUG: The contact display name used in the TO: field of the email is incorrect. It’s using the Contributor contact display name rather than the PCP owner display name. The TO: email address is correct however. (screenshot attached)

• BUG: If PCP is for an EVENT, the {$page_title} in the email is INCORRECT. Looks like it’s using the page_id to lookup a contribution page instead of an event. In my test, PCP was for sample event id=1 (Fall Fundraiser), the the owner notification showed ‘Help Support CiviCRM’.

• If not too hard, let’s add the URL to the PCP page to the owner notification. In text version, below the ‘You have received …’ line.
  In HTML version, make the {$page_title} a link.

• Event Registration linked from PCP (civicrm/event/register?id=1&pcpId=4&reset=1)
  Strict warning: Non-static method CRM_PCP_BAO_PCP::buildPcp() should not be called statically, assuming $this from incompatible context in CRM_Event_Form_Registration_Register->buildQuickForm() (line 545 of /Users/dgg/git/crm_v4.6/CRM/Event/Form/Registration/Register.php).

• Typo in conditional text on registration page:
  "This event registration is being made thanks to effort of $pcpOwner"

should be (add ‘the’ and change ‘effort’ to ‘efforts’) ...

"This event registration is being made thanks to the efforts of $pcpOwner"

PR link for above comment: https://github.com/civicrm/civicrm-core/pull/4994

Good work. The email notification works as expected. It is send when 'checked on' and not when 'checked off'.

Problem:
Editing an existing PCP shows two strange behaviors.
1. Unchecking 'notify' and clicking Save doesn't save the setting.
2. Clicking 'Cancel' returns you to the Drupal homepage, not to the PCP listing

Suggestions:

1. Seeing it in writing makes me realize "Owner Notification" is not clear what this does. Change field label to "Owner Email Notification". Add phrase "of new contributions" to label each option after the word "notifications". For example: "Owner chooses whether to receive notifications of new contributions"

2. "The donor's name has been added..." in the email text should be changed to "Their name has been added..."

Nileema -
1. Please check on the two issues reported by Stuart (Notify not saving, Cancel button redirect).

2. Let's implement the field label change (to "Owner Email Notification")

NOTE: The other text modifications unfortunately require writing another set of upgrade steps on top of what was done for Alpha 4, so I think we should skip those in the in the interest of keeping scope under control.

Hi,
Following things are taken care in PR- https://github.com/civicrm/civicrm-core/pull/5081
1. Unchecking 'notify' and clicking Save is saving correct setting.
2. Clicking 'Cancel' returns to the PCP listing.
3. Changed label from "Owner Notification" to "Owner Email Notification".

I am using CiviCRM 4.7.11. The label option "Owner Email Notification" shows up, but the input field or checkbox does not show up. This makes PCP for contribution pages unusable because "Owner Email Notification" is a required field, so when I try to save the settings, I get message saying "Owner Email Notification" needs to be filled out (which is impossible to do). It may have been fixed in 4.6 but it is not fixed in 4.7.11.

Eric this issue is part of new functionality that was actually introduced and 4.7

Here's a tip, when you reporting issue attempt to reproduce it on the demo site. This is not a denial of your personal experience, but rather it bolsters your report and it eliminates local variables and configurations as the cause of the issue.

My testing shows the button you speak of. See the attached images.

Thank you for also testing my issue. I too visited the demo.civicrm.org site. I did not find a 4.7.* demo site paired with Joomla. The latest version paired with Joomla on the demo site is 4.6.* Yes the issue seems to have been fixed in 4.6 (in the demo site at least). However, I saw that this issue (CRM-15821) was the same as what I was experiencing and I thought it may have been unfixed in 4.7.* If it is as you claim only on my installation, do you have any ideas on what would be causing it? It seems like a really odd thing to just break because of something else. The entire page even the label for the field input is viewable just that field input itself is none existent. The <td></td> tags are even there where the content element would be inserted between them. It just not likely that it is only my installation.

That's relevant that you use Joomla, and interesting that the demo site for Joomla is not 4.7. Regrettably I don't off the top of my head know a lot about Joomla, how to debug it, or what might be causing the missing checkbox. My guess would be: a configuration such as "from email address" or organization email address not configured, or a bug specific to Joomla. There likely isn't a reason to run 4.7.11 when 4.7.13 is available so the next step I suggest is an upgrade. If the problem persists, try a 'fresh install' of Joolma+4.7.13 on a test site, and see if the problem happens again.

If the problem persists, and you feel like it something that affects all 4.7.13 sites and not only your own, please create a new issue in JIRA, and link back to this one. A title like "PCP broken in Joomla" get attention, screenshots and error reports are always helpful, and all move your issue to the top of the queue.