Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-15924

Report form allows more criteria rows than template does

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.5.6
    • Fix Version/s: 4.6
    • Component/s: None
    • Labels:
      None
    • Documentation Required?:
      None

      Description

      The file located here:

      templates/CRM/Report/Form/Criteria.tpl

      allows the user to create an arbitrary number of criteria for the Order by Columns. However, if more than 4 criteria are created, javascript errors are thrown on report load. I tracked the problem down to the smarty template loop not creating the proper number rows.

      Below, you may see the diff of what I changed in the Criteria.tpl file.

      templates/CRM/Report/Form/Criteria.tpl templates/CRM/Report/Form/Criteria.tpl.old
      105c105
      <

      {section name=rowLoop start=1 loop=10}


      >

      {section name=rowLoop start=1 loop=6}

        Attachments

          Activity

            People

            • Assignee:
              atif.shaikh Atif Shaikh
              Reporter:
              jeffmikels Jeff Mikels
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3 minutes
                3m
                Remaining:
                Remaining Estimate - 3 minutes
                3m
                Logged:
                Time Spent - Not Specified
                Not Specified