CRM-16009 URL for Contact Image in View incorrectly generating

Jon,

It would be great if you can investigate on this.

Happy to. I am a terrible Javascript programmer, but I should be able to track down the problem.

i have identified it is at the View level. How I identified this is that I used the Views Raw SQL module hack a solution. When I use that module I get the correct URL then I just wrap that in an Image tag to show it correctly - concat('<img src=', civicrm_contact.image_URL, ' >') to create the image field. This works fine.

So it is happening somehow after it grabs that URL. Any ideas which module to look in for that?

Jon

Jon, did you look in https://github.com/civicrm/civicrm-drupal/blob/7.x-master/modules/views/civicrm/civicrm_handler_field_contact_image.inc

I think this is more than a minor issue, and should be fixed in the next 4.6.x release. It has broken all the Views that use any contact images in our site as well.

The view handler creates this code:
<img src="www.YOUR_SITE.com/sites/YOUR_SITE/files/styles/YOUR_STYLE/public/YOUR_SITE/civicrm/contact/imagefile%3Fphoto%3DYOUR_IMAGE_60cac351e611bf0c1f70091842ea0921.png?itok=vVZI4oPc" alt="" title="">

For some reason it's adding segments to the URL to go to the public files directory. But this is not where the image is stored, the src should simply be:
http://www.YOUR_SITE.com/civicrm/contact/imagefile?photo=YOUR_IMAGE_60cac351e611bf0c1f70091842ea0921.png

However this doesn't allow for a Drupal image style to be applied.

It doesn't look like the Views handler file has changed in the latest version, so something must have changed in CiviCRM to cause this?

I have a site that is affected by this bug as well. As John.K notes, the image URL has two issues: (1) the query string is getting URL encoded, stripping "?" and "=", and (2) the path is incorrect, both with or without the Drupal image style applied.

CiviCRM is no longer returning urls to drupal views in the format
'files/customuploaddir/filename.jpg'
but sending this instead
'/civicrm/contact/imageFile?photo=filename.jpg'

This breaks because drupals theme_image_style url encodes it and its not a url in the files directory so drupal can't find it.

Im going to try and work out why CiviCRM has changed the way it returns the image urls but in the meantime..

A temporary fix to convert the ?photo=url.jpg to public://customuploaddir/filename.jpg so that the images will work again and with image_styles

civicrm/drupal/modules/views/civicrm/civicrm_handler_field_contact_image.inc ~line 150

$url_parts = array_slice($url_parts, $files_key + 1);

/*
Temp fix for breaking changed in 4.6
Drupal URL encodes image urls that have ? = in if they start with public://
So if the url includes ? = then change url
*/

if( strpos ( $img_url, '?') === FALSE)

else

/* end temp fix */

$image_info = image_get_info($file_path);

Here is a stab at fixing it: https://github.com/civicrm/civicrm-drupal/pull/278

John, Link, Alex - please grab Coleman's PR and test your cases and get back to us.

That fixed the issue on civicrm.org's views.

Hi, this fix doesn't quite do the trick.

I confirm that it fixes Views when the default (original) image is used. It also fixes the display of 'empty' contact images.

However it doesn't work when an image style is applied to the contact image in the field settings for the contact image > Set image style options > Image style. This results in broken URLs, eg:
https://styles/150px_square/https/[site]/civicrm/contact/imagefile?photo=[image]_1ba8ae4df0da4b77de36de6164bf8a2b.png&itok=eSeYqpie

The part of the code that breaks up the URL seems to be putting https into the path, but that's certainly not the only issue!

John - If you can investigate and propose additional changes that would be great.

Let's reopen the issue? I'll take a look when I can but it's not on our hit list at the moment.

Maybe better to file a new 'related' issue for the 'image style' problem.

Righto, done: CRM-16479

Using 4.6.6 with a view that uses "original image" (not the Drupal image style; those are completely broken in 4.6.6) my contact images load inconsistently. When the browser loads the page, some images load but not others. You can see in screencast where I am just refreshing the browser on my view: https://drive.google.com/a/mustbuilddigital.com/file/d/0B3nAbo5lFYReRmZ0LTdFS19Pc1k/view?usp=drivesdk

I believe this is because the src is http://YOURSITE/civicrm/contact/imagefile?photo=photo_file.jpg and the civicrm/contact/imagefile? script is too slow to get the image to the browser in time and it times out. Is there a way to hack crm_handler_field_contact_image.inc so that it uses the straight file path for the contact image?

Link Swanson you may need to do some server performance tuning. By design, contact images are not publicly accessible which is why they must be loaded with a php script.
Here's a good resource: https://www.youtube.com/watch?v=k1ov2feFrCU&feature=youtu.be