CRM-16492 "New smart group" process is not accurately portrayed and is very misleading.

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.5.8, 4.6.2
    • Fix Version/s: 4.6.6
    • Component/s: Core CiviCRM
    • Labels:
      None
    • Documentation Required?:
      None
    • Funding Source:
      Core Team Funds

      Description

      In 4.4 if you did an advanced search, selected only some of the results and then selected the action "New smart group", the process didn't proceed and there was a notice (attached) displayed on the screen.

      In 4.5 and 4.6 there is no warning and the smart group is created based on the search criteria that defines the entire set of results even if only one of the results was "ticked" before the action was selected.

      This is, of course, the way a smart group works, the search criteria defines it. However, the lack of a warning and the creation of the smart group when not all results are selected falls somewhere between "not helpful" and "terribly misleading" for people who do not fully understand how smart groups work. (And that will be almost anyone who is new to CiviCRM.)

      The warning and the stopping of the "New smart group" action need to be re-instated IMO.

        Attachments

          Activity

          [CRM-16492] "New smart group" process is not accurately portrayed and is very misleading.
          Coleman Watts added a comment -

          I went down the road of some overcomplicated clientside validation and finally realized that this is really about communicating with the user, and the popup warning in your screenshot isn't doing a very good job of that so why duplicate it? Here's a simpler and better solution (simple enough IMO to go into 4.6)
          https://github.com/civicrm/civicrm-core/pull/6111

          Joanne Chester added a comment -

          I must admit I think it was better when it wouldn't let you create a smart group if you didn't select all of the search results. However, I can't create a patch that does that and I don't feel strongly enough about it to use my personal money to pay someone else to do it.

          What I could do, if you agree, is create a patch to change the new wording to something even more pointed. How about:

          "This smart group will stay up-to-date with all contacts who meet the search criteria.

          NOTE: Even if only a few contacts have been selected from the search results, all contacts that meet the search criteria will be in the group.

          (learn more...)"

          Coleman Watts added a comment -

          Joanne Chester sure, go for it

          Joanne Chester added a comment - - edited

          https://github.com/civicrm/civicrm-core/pull/6304

          Should I also do a PR against master?

          Joanne Chester added a comment -
          David Greenberg added a comment -

          Closing since PR for 4.6 is merged.

            People

            • Assignee:
              Coleman Watts
              Reporter:
              Joanne Chester

              Dates

              • Created:
                Updated:
                Resolved: