Details
-
Type: Bug
-
Status: Done/Fixed
-
Priority: Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.5.8, 4.6.2
-
Fix Version/s: 4.6.6
-
Component/s: Core CiviCRM
-
Labels:None
-
Documentation Required?:None
-
Funding Source:Core Team Funds
Description
In 4.4 if you did an advanced search, selected only some of the results and then selected the action "New smart group", the process didn't proceed and there was a notice (attached) displayed on the screen.
In 4.5 and 4.6 there is no warning and the smart group is created based on the search criteria that defines the entire set of results even if only one of the results was "ticked" before the action was selected.
This is, of course, the way a smart group works, the search criteria defines it. However, the lack of a warning and the creation of the smart group when not all results are selected falls somewhere between "not helpful" and "terribly misleading" for people who do not fully understand how smart groups work. (And that will be almost anyone who is new to CiviCRM.)
The warning and the stopping of the "New smart group" action need to be re-instated IMO.
I went down the road of some overcomplicated clientside validation and finally realized that this is really about communicating with the user, and the popup warning in your screenshot isn't doing a very good job of that so why duplicate it? Here's a simpler and better solution (simple enough IMO to go into 4.6)
https://github.com/civicrm/civicrm-core/pull/6111