Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-16921

Nightly build include old DAO files

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7
    • Fix Version/s: 4.7.0
    • Component/s: None
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Core Team Funds

      Description

      On Mon, Jul 27, 2015 at 4:35 PM, Eileen McNaughton wrote:

      Hey Tim,

      I thought this might be a bug ... but maybe it is a feature...

      The tarballs I generate using distmaker don't work (that's what I'm digging into - but to do with class loader update that isn't in my tarball) but in the process I noticed my tarballs don't have old DAO files but the nightly builds do.

      e.g if I untar the drupal one from here

      http://dist.civicrm.org/by-date/latest/4.6/

      I find the file CRM/Activity/DAO/ActivitiyAssignee exists.

      I was going to stick in JIRA but then thought maybe there is method...

      REPLY from Tim

      I think the difference is that dist.civicrm.org is configured to checkout+rebuild all the tags/branches (if they've changed), and I suspect that you're only building one or two. If the theory is right, then symptom would be a bit racy (depending on which branches have been modified in recent days).

      What we're probably missing is a 'make clean' type step in between builds. It does rerun GenCode between revisions, but GenCode leaves behind stale DAOs.

      Might be good to file an issue with label SprintCandidate.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: