Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Trivial
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.6.6
-
Fix Version/s: 4.6.7
-
Component/s: None
-
Labels:None
-
Documentation Required?:None
-
Funding Source:Needs Funding
Description
Hi Coleman, I wanted to get your feedback on this, after briefly discussing with Tim on IRC. I don't deal with price sets via js much but when others do there always seems to be much cussing about classes & html structure. I just needed to do some & it seemed to me that adding data classes to the html was potentially a fix. In the case of the piece I was working on I want to know the membership_type_id & num_terms of the selected option - both values in the price_field_value table.
I'll do a PR of what I think might improve this & you can feedback. The data in the table doesn't seem to be sensitive.
Attachments
Issue Links
Activity
Serializing $customOption seems fine to me provided that it doesn't contain any sensitive data or any huge blobs of data to bloat the dom.
Hey Monish - I'm ok to merge this & coleman is too. We discussed it briefly. Do you want to check how it works in your use case before we merge? Or should we just merge?
I just came to know how it gonna help in my use-case, so yes to merge 
OK merged - I'd like to see how you put it to use - I think I'm already a watcher on that ticket though
Proposal : https://github.com/civicrm/civicrm-core/pull/6468