CRM-17143 non-static method CRM_Campaign_Page_AJAX::campaignList() should not be called staticall

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.6.8
          • Fix Version/s: 4.7.2
          • Component/s: None
          • Labels:
          • Documentation Required?:
            None
          • Funding Source:
            Needs Funding

            Description

            I hit this on master - but we should fix non static functions like this in 4.6 I think

            non-static method CRM_Campaign_Page_AJAX::campaignList() should not be called statically in call_user_func() (line 375 of /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/CRM/Utils/REST.php). =>

              Attachments

                Activity

                [CRM-17143] non-static method CRM_Campaign_Page_AJAX::campaignList() should not be called staticall
                Eileen McNaughton added a comment -

                Another one
                Strict warning: Non-static method CRM_Custom_Page_Option::actionLinks() should not be called statically in actionLinks() (line 157 of /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/CRM/Core/BAO/CustomOption.php). =>

                Coleman Watts added a comment -

                Eileen McNaughton you sending up a PR for this?

                Eileen McNaughton added a comment -

                I think it was just an error I noticed & logged while doing something else

                Saurabh Batra added a comment -

                https://github.com/civicrm/civicrm-core/pull/7803
                Set up a straight forward PR for this. However, the CRM_Custom_Page_ classes are calling their actionLinks functions both statically and non-statically. I think a separate PR should address them.

                Eileen McNaughton added a comment -

                Thanks Saurabh - should we close this or address those others against this?

                Saurabh Batra added a comment -

                I'll make a new issue and fix them there.

                  People

                  • Assignee:
                    Saurabh Batra
                    Reporter:
                    Eileen McNaughton

                    Dates

                    • Created:
                      Updated:
                      Resolved: