CRM-17918 Multiple-record custom field data displays as "[object Object]"

          Details

          • Documentation Required?:
            None
          • Funding Source:
            Needs Funding

            Description

            In 4.7.0 a problem has appeared with custom field data displaying incorrectly in "tab with table" for multiple-record custom fields (I posted on stackexchange here)

            When two or more multiple-record custom field groups exist the following will often, but not always, occur:

            • The values for some columns will all display as "[object Object]"
            • The values for some columns may appear in the wrong column, and "View Edit more >" may be missing
              See attached screenshot.

            I initially noticed this on my Joomla system after upgrading to 4.7.0 (did not occur in 4.6.11 and earlier), but have also seen the problem in 4.7.0 on a local Drupal test installation. Note: the 4.7 demos on both Drupal and Wordpress (Joomla is an old version) exhibit different behaviour - "No records of type '' found." is seen in cases where custom records do exist.

            Steps to reproduce:

            1. Create a custom field group, Custom1, set to allow multiple records and use default of "tab with table"
            2. Create two alphanumeric fields and two date fields in Custom1
            3. Enter two records in Custom1
            4. Create another custom field group, Custom2, as per Custom1
            5. Enter two records in Custom2
            6. View any contact
            7. Click on Custom 1 tab then click on Custom 2 tab
            8. Problem will usually be evident by now but if not refresh page in browser and click on Custom1 then Custom2 tab again (the order seems important)

            When bad data is displayed, attempting to sort the DataTable by a column will give this error in browser: "DataTables warning: table id=records - Invalid JSON response."

              Attachments

                Activity

                [CRM-17918] Multiple-record custom field data displays as "[object Object]"
                Coleman Watts added a comment - - edited

                Monish Deb this may be related to CRM-17810.
                Jitendra Purohit from the description it sounds like a js scoping issue. Pls make sure that

                1. the code does not rely on any dom ids
                2. all js is scoped and not global
                3. scope is always passed into jQuery e.g. $('table', $section) and not just globally selecting $('table')
                Jitendra Purohit added a comment -

                Submitted a PR - https://github.com/civicrm/civicrm-core/pull/7720. Thanks!

                Andrew Thompson added a comment -

                Thanks for the work done on this. I'm still seeing "DataTables warning: table id=records-7 - Invalid JSON response." when attempting to sort some columns in the DataTable. Is that related, or a separate issue?

                Jitendra Purohit added a comment -

                Hey Andrew,

                I tried to replicate the error you mentioned by taking around 10 to 15 entries for each fields in custom sets. I was able to sort by all of them and the warning message was not displayed for me. Can you try again by rebuilding the menu with "<your_site_name>/civicrm/menu/rebuild?reset=1" ?

                It would be helpful if you could list the steps and mention for which field the sorting doesn't work for you.

                Thanks,
                Jitendra

                Andrew Thompson added a comment -

                Hi Jitendra,
                I checked again and am still able to reproduce the "DataTables warning: table id=records-7 - Invalid JSON response." error. This time I tested on the 4.7.1 release on both Joomla and Drupal (and did rebuild the menu). Let me know if you need any more detail, or if I should log this as a new issue (I'm unsure if it's the same thing as before).

                Note that the first Custom tab works ok and it is only the second (or 3rd, ...) custom tab that will display the problem.

                These steps should reproduce it:

                1. Create a custom field group, Custom1, set to allow multiple records and use default of "tab with table"
                2. Create two alphanumeric text fields "Field1" and "Field2" and two date fields of format dd/mm/yyyy "Date1" and "Date2" in Custom1
                3. Create another custom field group, Custom2, with the same fields as Custom1
                4. View any contact
                5. Enter two records in Custom1
                6. Enter two records in Custom2
                7. Refresh the contact
                8. Click on Custom 1 tab then click on Custom 2 tab
                9. Try to sort data on each column. This should produce the error.

                I also tried testing again In the CiviCRM 4.7.2 Drupal sandbox but I couldn't because only the first custom field tab works; the second always displays "No records of type '' found." even when there are records existing.
                Thanks again,
                Andrew

                Jitendra Purohit added a comment - - edited

                Hey Andrew - Unfortunately, the steps mentioned above still doesn't replicate the error for me. The sorting works without any warnings or console errors. I tested with the same date formats and field types. The behaviour shown at demo server is also weird (may be its not updated ).

                  People

                  • Assignee:
                    Jitendra Purohit
                    Reporter:
                    Andrew Thompson

                    Dates

                    • Created:
                      Updated:
                      Resolved: