CRM-19072 Batch update - Can't modify custom fields for a contact with 2 subtypes

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.6.19, 4.7.9
          • Fix Version/s: 4.7.10
          • Component/s: None
          • Labels:
          • Documentation Required?:
            None
          • Funding Source:
            Contributed Code

            Description

            When a contact has two subtypes, it is impossible to batch update custom fields via a profile.

            Steps to reproduce the bug:

            1. Create custom fields (image : batch_update-custom fields.png)
            2. Create a profile with this fields + a common fields like Middle Name (image : batch_update-profile.png)
            3. Create or use 2 subtypes like Student and Parent. And add this subtype to a contact. In my screen capture, it's Barkley Delana.
            4. Modify this contact via the profile. (image : batch_update-before.png)

            (This procedure can be tested today on Civicrm demo site with custom fields and profile that i have created : http://dmaster.demo.civicrm.org/civicrm/admin/uf/group?reset=1 )

            As you can see, on my screen captures, for the contact with 2 subtypes, custom fields are not updated. (image : batch_update-after.png)

              Attachments

              1. batch_update-after.png
                186 kB
                Philippe SAMPONT
              2. batch_update-before.png
                187 kB
                Philippe SAMPONT
              3. batch_update-custom fields.png
                173 kB
                Philippe SAMPONT
              4. batch_update-profile.png
                196 kB
                Philippe SAMPONT

                Activity

                [CRM-19072] Batch update - Can't modify custom fields for a contact with 2 subtypes
                Philippe SAMPONT added a comment -

                I found the cause, it is this line 2247 of file CRM/Contact/BAO/Contact.php : 

                $type = $type[0];

                However, I do not understand the purpose of the comment.

                          if (!empty($data['contact_sub_type'])) {
            $type = $data['contact_sub_type'];
            $type = explode(CRM_Core_DAO::VALUE_SEPARATOR, trim($type, CRM_Core_
DAO::VALUE_SEPARATOR));
            // generally a contact even if, has multiple subtypes the parent-type is going to be one only
            // and since formatCustomField() would be interested in parent type, lets consider only one subtype
            // as the results going to be same.
            $type = $type[0];
          }
                Coleman Watts added a comment -

                It looks to me like the function CRM_Core_BAO_CustomField::formatCustomField originally did not accept an array but now it does, so it should be safe to remove that line. If that solves the problem for you, please submit a pull-request that removes the 3-line comment and the $type = $type[0]; line of code.

                Philippe SAMPONT added a comment -

                Pull Request submitted : https://github.com/civicrm/civicrm-core/pull/8704

                It's my first contribution to CiviCRM, I hope I've done this correctly.

                Monish Deb added a comment -

                Philippe SAMPONT thanks for contribution and good work I have assigned myself for QA and will merge if everything works fine

                Monish Deb added a comment -

                Tested, working fine

                  People

                  • Assignee:
                    Monish Deb
                    Reporter:
                    Philippe SAMPONT

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Time Tracking

                      Estimated:
                      Original Estimate - 2 hours
                      2h
                      Remaining:
                      Remaining Estimate - 2 hours
                      2h
                      Logged:
                      Time Spent - Not Specified
                      Not Specified