CRM-19368 Invalid argument for foreach in /administrator/components/com_civicrm/civicrm/CRM/Report/Form/Contact/Relationship.php

Stephen Palmstrom yes please, a PR would be helpful to the review/merge process. And could you please do 2 commits to separate the function changes from the comment cleanup?
In the beginning of your patch you remove ts() from the strings which will break translations of the form - can you explain why that was needed?

Thanks for your feedback. I have never been clear as to the purpose of ts(), but having mentioned translations, I think I understand. Which is the fork from which I should generate the PR? I always find it difficult to decide which should be used.

Hi Stephen Palmstrom I would recommend you generate your fork from the master branch of core. Most of the time you will be working off of that.

Stephen Palmstrom One thing that could make the patch smaller is that just before the foreach you could do something like this

$relationshipIds  = is_array($this->_params['relationship_type_id_value']) ?: array($this->_params['relationship_type_id_value']); 

Then do the foreach on $relationshipIds

Good thinking. I tend to use if (...)

as it is more readable, and from my experience with other programming languages. Your suggestion makes excellent sense.

Stephen Palmstrom Stephen even if you wanted to do and if () { }

you could do if (!is_array($this->_params['relationship_type_id_value'])) {
$relationshipIds = array($this->_params['relationship_type_id_value']);
else

The main thing would be is that you wouldn't have to duplicate the $relationship_type stuff etc as then your dealing all the time in arrays

Really good thinking. I just put in a quick workaround, but your ideas are much better.

Stephen Palmstrom have you opened a pull request? It will automatically link from this issue if you put CRM-19368 in the title. Otherwise just paste a link to it here.

Sorry, not yet. One of my jobs for today.

I have now created the PR, I hope to your satisfaction.

PR https://github.com/civicrm/civicrm-core/pull/9154 has been merged.