CRM-19442 preferred_mail_format should never be NULL or handled properly

          Details

          • Type: Bug
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Fixed/Completed
          • Affects Version/s: 4.7.9, 4.7.11
          • Fix Version/s: 4.7.13
          • Component/s: CiviMail
          • Labels:
            None
          • Documentation Required?:
            None
          • Funding Source:
            Needs Funding

            Description

            if "nothing" is selected on a contact's preferred e-mail format, then empty mails are being sent.

            Either "nothing" shouldn't be an allowed option or it should be handled by CiviMail as "both".
            Looking into the database I see that there are both empty values and NULL in that column. Empty values are currently treated as "both". I think it should be the same for null. Sending an empty e-mail is bad, especially as the user doesn't see it.

              Attachments

                Activity

                [CRM-19442] preferred_mail_format should never be NULL or handled properly
                Monish Deb added a comment -

                Manuel Schneider From UI it seems like we cannot choose "nothing" for preferred_mail_format as it is a required format. See here where I try to submit "nothing"

                Seamus Lee added a comment -

                This was fixed as part of https://issues.civicrm.org/jira/browse/CRM-18157 and https://issues.civicrm.org/jira/browse/CRM-19423 Relevant PRs are https://github.com/civicrm/civicrm-core/pull/9086 and https://github.com/civicrm/civicrm-core/pull/9134

                Seamus Lee added a comment -

                PRs are merged

                  People

                  • Assignee:
                    Samuel Vanhove
                    Reporter:
                    Manuel Schneider

                    Dates

                    • Created:
                      Updated:
                      Resolved: