Details
-
Type:
Task
-
Status: Done/Fixed
-
Priority:
Important
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.7.13
-
Fix Version/s: 4.7.19
-
Component/s: None
-
Labels:
-
Versioning Impact:Patch (backwards-compatible bug fixes)
-
Documentation Required?:None
-
Funding Source:Contributed Code
-
Verified?:No
Description
CRM-16189: Improve support for Accrual Method bookkeeping included support for migrating data from CiviCRM to an accounting package at the summary level at the end of an accounting period, as requested numerous times over the years, rather than having all of the transaction detail go to the accounting system. When the community started pushing back at having new functionality in core, I decided this portion of the work could be relatively easily put into an extension. At another level, there was an uneasiness with putting into core some of this functionality like a trial balance and close accounting period function since this brought us too close to replicating accounting system functionality. Moving it to an extension seemed like a good idea.
A very small number of users may have made use of this unadvertised functionality, given there were lingering concerns about the trial balances calculated before the accounting periods were closed on 2nd and subsequent periods.
On upgrade, check if there are values in the fields to be dropped, and if so, install the extension, and copy the values of the fields to be dropped from the core table (civicrm_financial_account) to the extension table. If there are no values, do not install the extension and do proceed to drop the fields.
Attachments
Issue Links
- supplements
-
CRM-20268 Support deferred revenue accounting, etc.
-
- Open
-
- links to
Activity
Joe Murray Can you please review?
I'm a bit confused about the title of the PR refering to CRM_16189. Can you explain to me a bit more what's going on, and in particular, the status of the large amount of code that has not been merged for CRM-16189 and the smaller portion that has.
IIRC, commits for some schema changes and a few other things that were more like refactoring and less like adding functionality were merged in a few releases ago.
The code for the extension to support closing Accounting Periods, including schema changes to provide balances on financial accounts, trial balance reports, and closing accounts for the month should all go into a 'core' extension to be supported by JMA Consulting. Can you show me the code you are removing from core in the extension? Thx.
Joe Murray, i have updated the PR and have moved all te code into an extension https://github.com/JMAConsulting/biz.jmaconsulting.closeaccountingperiod
Can you please review it?
Just noting that this code should go before the ticket gets closed
//CRM-16189
if (CRM_Contribute_BAO_Contribution::checkContributeSettings('financial_account_bal_enable')) {
$this->add('text', 'opening_balance', ts('Opening Balance'), $attributes['opening_balance']);
$this->add('text', 'current_period_opening_balance', ts('Current Period Opening Balance'), $attributes['current_period_opening_balance']);
$financialAccountType = CRM_Core_PseudoConstant::get(
'CRM_Financial_DAO_FinancialAccount',
'financial_account_type_id',
array('labelColumn' => 'name')
);
Eileen McNaughton are you referring to this https://github.com/civicrm/civicrm-core/pull/9974/files#diff-15cfbac79d793ca9dc2cb062a8cc44daL108 ?
I think we can safely say yes. Could you grep for any other references to settings being deleted? Thx.
Submitted PR at https://github.com/civicrm/civicrm-core/pull/9498