Details
Important
Description
The default mailing list subscription form in CiviCRM does not include form labels for mailing list group options. This poses an accessibility barrier for screen reader users, and results in the page failing automated accessibility tests (i.e. Wave Accessibility Evaluation).
Attachments
Issue Links
Activity
Hi Jon,
I can submit a pull request for the update. Do you have any documentation for accessing the Git repo for CiviCRM?
Thanks.
-Trip
Hi Trip,
There's documentation here: https://wiki.civicrm.org/confluence/display/CRMDOC/Contributing+to+CiviCRM+using+GitHub
However, that documentation was recently cited as "in need of cleanup", since it prints out to 8 pages of text. Nevertheless, if you're git-savvy, you should be able to skim it for the necessary details.
Hi Jon,
Thanks for sending the link to CiviCRM docs. I submitted a pull request with the updates. Here is a summary of changes to Subscribe.tpl:
- Added form labels to identify mailing list selections (WCAG 2.0 requirement)
- Removed the table summary (used for data tables only)
Thanks.
-Trip
PR https://github.com/civicrm/civicrm-core/pull/9606 has been merged.
Thank you for this update - and especially for running accessibility tests on CiviCRM.
Do you have a Github account? Typically patches to CiviCRM are submitted as pull requests on Github. This allows us to run automated tests on every submission and reduces the general grunt work involved in keeping code quality high. I'm happy to help you get started with Github if you like on https://chat.civicrm.org in the "dev-newcomers" channel.
If that's more than you're up to right now, I'll package this up for you, in deference to your being a member organization and this being your first patch. We appreciate your contribution far more than we wish it to be in the right format!
Please let me know how you'd like to proceed on packaging this and we'll proceed accordingly.