Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-19805

Comparing instead of Assigning

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.14
    • Fix Version/s: 4.7.16
    • Component/s: Core CiviCRM
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      Hi!
      We checked the source code by static analyzer AppChecker. It found several suspicious places (сomparing instead of assigning):

      1) CRM/Core/BAO/CMSUser.php#L199

            if ($emailName == NULL) {
              $errors['_qf_default'] == ts('Could not find an email address.');
              return $errors;
            }
      

      2) CRM/Core/Payment/PayflowPro.php

          if ($params['installments'] == 1) {
            $params['is_recur'] == FALSE;
          }
      

      3) CRM/Event/Page/ParticipantListing/Name.php

        public function preProcess() {
          $this->_participantListingType == 'Name';
          parent::preProcess();
        }
      

        Attachments

          Activity

            People

            • Assignee:
              yashodha Yashodha Chaku
              Reporter:
              AppChecker AppChecker
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: