Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-19830

Cleanup contribution search by making non-exportable fields exportable

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.14
    • Fix Version/s: 4.7.16
    • Component/s: None
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Needs Funding
    • Verified?:
      No

      Description

      I've been looking into some performance issues & have been struggling with unnecessary hackiness in the code.

      After some analysis I found that 4 fields in the Contribution schema have not been declared as exportable. In each case some hackery has been done to declare them after the fact. The fields are

      payment_instrument_id
      contribution_recur_id
      financial_type_id
      address_id

      The first 3 of these have been hacked into the BAO::exportableFields function - which is the only place affected by the 'export' flag. Thus changing the schema to declare them as exportable will have no change other than requiring some code cleanup.

      The last one, address_id is hacked into the contribution search. Adding export=True to this one will mean the address id can be searched on in search builder & exported. While I can't see a particular use for this I can't see a downside either.

        Attachments

          Activity

            People

            • Assignee:
              eileen Eileen McNaughton
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: