CRM-19891 Installment text often looks different then contribution text due to inconsistent use of label tag

          Details

          • Type: Bug
          • Status: Open
          • Priority: Trivial
          • Resolution: Unresolved
          • Affects Version/s: 4.7.15
          • Fix Version/s: None
          • Component/s: CiviContribute
          • Labels:
          • Versioning Impact:
            Patch (backwards-compatible bug fixes)
          • Documentation Required?:
            None
          • Funding Source:
            Needs Funding
          • Verified?:
            Yes

            Description

            Due to the way frequency intervals are dynamically added to the contribution page, we often get the text: "I will contribute this amount" wrapped in a label tag and the following text "every month" not wrapped in a label tag. This inconsistency often creates a visual difference which could be fixed using a CSS work-around... but since both parts of the text are in fact labels, it is more elegant to fix it in the code.

            Here's the HTML snippet:

            <input id="is_recur" name="is_recur" value="1" class="crm-form-checkbox" type="checkbox"> <label for="is_recur">I want to contribute this amount</label> every month

              Attachments

                Activity

                [CRM-19891] Installment text often looks different then contribution text due to inconsistent use of label tag
                Jamie McClelland added a comment -

                https://github.com/civicrm/civicrm-core/pull/9692

                Sean Madsen added a comment -

                I am working on reviewing this PR

                • I am able to observe that the text "every month" is not placed within the <label> tag.
                • I too would expect this text to be placed within the <label> tag, so I can verify that this behavior appears to be a bug
                • It's worth mentioning though that I'm unable to straightforwardly reproduce any inconsistent styling as seen in the screenshot of this ticket. I tried in Drupal 7 and observed that the following themes all produced consistent styling: "Seven", "Bartik", and "Garland". But I would still consider this ticket "verified" now since I can see how, with the necessary theme CSS, the inconsistent style could arise.
                Jamie McClelland added a comment -

                This issue was verified months ago - just update the status.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Jamie McClelland

                    Dates

                    • Created:
                      Updated: