Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-20061

All 'tables' as a parameter on the revert api

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.17
    • Fix Version/s: 4.7.17
    • Component/s: CiviCRM API
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      Developer Doc
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      The revert api reverts the changes associated with a particular change based on the data in the logging tables. It currently calculates a list of tables to revert from. This issue creates the opportunity to pass in a list of tables to revert.

      In doing the PR I identified a fatal error under some circumstances - where the contact is not updated it 'touches' the contact record to trigger the triggers to update the modified_date. The triggers are now smarter than they were when that code was done and changing a record with no change no longer triggers an update. However, changing related records does trigger an update - I was able to prove the code is useless and redundant by adding a unit test

        Attachments

          Activity

            People

            • Assignee:
              eileen Eileen McNaughton
              Reporter:
              eileen Eileen McNaughton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: