Details
Description
Not really a bug, but since there has been an agreement to use
{contact.email_greeting}
, some templates are not in agreement to that leading to confusion and despair. So sad.
Some of the templates I found that need to be changed are:
- Additional Payment Receipt or Refund Notification
- Contributions - Recurring Billing Updates
- Contributions - Recurring Cancellation Notification
- Contributions - Recurring Start and End Notification
- Contributions - Recurring Updates
- Contributions - Receipt (on-line) (missing greeting)
- Events - Registration Confirmation Invite
- Events - Registration Cancellation Notice
- Events - Receipt only
- Events - Pending Registration Expiration Notice
- Memberships - Auto-renew Billing Updates
- Memberships - Auto-renew Cancellation Notification (missing greeting)
- Personal Campaign Pages - Owner Notification (missing greeting)
- Personal Campaign Pages - Supporter Welcome
- Petition - need verification (missing greeting)
- Petition - signature added (missing greeting)
- Pledges - Acknowledgement
- Pledges - Payment Reminder
- Volunteer - Registration (on-line)
Actually the only ones that already have it are:
- event_offline_receipt_html.tpl:24
- event_offline_receipt_text.tpl:1
- event_online_receipt_html.tpl:28
- event_online_receipt_text.tpl:1
- sample/Sample Responsive Design Newsletter
Some have: <p>
{ts 1=$contact.display_name}
Dear %1
{/ts}
,</p>
Some have: <p>Dear
{contact.display_name}
,</p>
Some have event: <p>Dear {$contactDisplayName}</p>
Some have missing greetings
Since these are not files but live in the database I'm not sure what kind of patch is needed for this, being a result of my novice development skills
If someone would show me how to create upgrade files for this, I'm willing to attempt to create a PR.
I hope I helped the community by identifying this and hopefully we can make CiviCRM more consistent.