Details
-
Type:
Sub-task
-
Status: Open
-
Priority:
Trivial
-
Resolution: Unresolved
-
Affects Version/s: 4.7.16
-
Fix Version/s: 4.7.18
-
Component/s: None
-
Labels:
-
Versioning Impact:Patch (backwards-compatible bug fixes)
-
Documentation Required?:None
-
Sprint:4.7.14 Financial
-
Funding Source:Needs Funding
-
Verified?:No
Description
To replicate:
1. Enable Sales tax
2. Define sales tax relationship between Financial Type and Financial Account (Having 10% tax rate)
3. Add Priceset having Checkbox, Radio, Text and Select field as price fields with Financial Type having sales tax rate.
4. Added contribution using contribution form using priceset(#3).
5. Update the contribution with
5.a
civicrm_api3('Contribution', 'create', array(
'id' => 1,
'financial_type_id' => "Donation", (choose the same FT)
));
Result: Contribution Total, Financial Trxn, Financial Item - Correct
Line Item(tax_amount) entries - InCorrect
Attached image AddContrbutionLineItemAPI.png(before update) and UpdateContributionLineItemAPIOnlyFT.png(after update)
5.b
civicrm_api3('Contribution', 'create', array(
'sequential' => 1,
'id' => 1,
'financial_type_id' => "Donation",
'total_amount' => 336.60
));
Result:
Contribution Total - Incorrect (amount changed)
Financial Trxn, Financial Item - Additional Entries for amount change
Line Item(tax_amount) entries - InCorrect
Attached image AddContrbutionLineItemAPI.png(before update) and UpdateContributionLineItemAPITotalAmount&FT.png(after update)
Regression:
https://github.com/civicrm/civicrm-core/pull/8835
Attachments
Issue Links
- is supplemented by
-
CRM-21588 When updating contribution with tax having multiple price item, each item get the total tax amount
-
- In Progress
-
- links to
Activity
A bit tangential but we might want to add some validation after contribution is saved that the total of line items correspond to the total of the contribution (and the taxes total correspond to the total of taxes from all the corresponding line_items) because it seems to be possible to do virtually anything using the api...
There is 2 ways to solves this i believe :
- either forbid to have multiple priceset for the same contribution (add a validation for the api)
- or allow the possibility but ensure the UI is minimally able to deal with it : the UI should display all the line items and be able to save properly without breaking the current line items (I prefer this one but might be more complex)
If you create a contribution with multiple line item from different price sets via the api and update the contribution using the UI, you have the same problem.
We'd like to make advanced invoicing but if we do, the user cannot update the contribution without breaking the line items.