CRM-2032 Changing the 'name' of the Mailing Name input box would improve browser AutoComplete behaviour

          Details

          • Type: Improvement
          • Status: Done/Fixed
          • Priority: Trivial
          • Resolution: Won't Fix
          • Affects Version/s: 1.7
          • Fix Version/s: 1.8
          • Component/s: CiviMail
          • Labels:
            None

            Description

            Step 1 of sending a mailing in CiviMail has a single field to enter called "Mailing Name". In my Firefox browser, AutoComplete suggestions for the input field include a variety of contact names and other poor choices for a Mailing Name.

            I believe this is because the source code for the input field assigns the input box properties (id and/or name) generically as "name" in the following HTML snippet:
            <input maxlength="128" size="45" name="name" type="text" id="name" class="form-text huge required" />
            This then matches with other unrelated input boxes also called name.

            My suggestion would be to replace the "name" property values to something more specific like "mailing_name"

              Attachments

                Activity

                [CRM-2032] Changing the 'name' of the Mailing Name input box would improve browser AutoComplete behaviour
                Piotr Szotkowski added a comment -

                I agree with Chris; Dave, when you're working on CiviMail's UI, can you also fix this?

                If not, reassign this to me and I'll do the fix.

                David Greenberg added a comment -

                P - This change will affect postProcess etc. and I'm not setup to test/make sure I don't break stuff. So assigning back to you (Thx).

                Donald A. Lobo added a comment -

                We try to maintain consistency between form name / database name etc and avoid db -> form name translations etc. SInce we use pretty descriptive table names, we keep field names the same across multiple tables and avoid prefixing.

                Hence, I dont think renaming name to mailing_name is a good idea. If we do decide to do so, we should make a blanket change throughout the system

                Manish Zope added a comment -

                Verify for 2.0

                Manish Zope added a comment -

                Issue is already verified for 2.0, hence closing it.

                  People

                  • Assignee:
                    Shailesh Lende
                    Reporter:
                    Chris Mott

                    Dates

                    • Created:
                      Updated:
                      Resolved: