Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Important
-
Resolution: Fixed/Completed
-
Affects Version/s: 4.7.19
-
Fix Version/s: 4.7.28
-
Component/s: CiviReport
-
Labels:
-
Versioning Impact:None (no code merged)
-
Documentation Required?:None
-
Funding Source:Core Team Funds
-
Verified?:Yes
Description
Just upgraded a site from 4.7.15 to 4.7.19. The upgrade went smoothly without error. The site uses a contact report, which simply lists contacts in a given group. This was working fine and used solely as a dashlet on the CiviCRM dashboard prior to the update. Post update, the report now includes contacts that have been 'soft' deleted, i.e. moved to the Trash. Consequently, the report is now useless.
Attachments
Issue Links
Activity
This continues to be a bug on 4.7.25, reproducable on the demo site. I think prompter attention to end-user and reporting issues such as this would set an example that would help present CiviCRM as a solution. 
Stoob can you try out this PR? It fixes the constituent summary report, the top donors report, and the event participant list report. There may be others that need fixing too, but those were the ones I found in my spot-checking.
Coleman Watts thanks, I can confirm the PR changes filters out deleted contacts on _these _reports. I found, however, that this fix did not affect Mail Opened Report and Donor Report (Detail) which still show deleted contacts after patch (see attached). I would offer that likely all mailing reports and contribution reports are affected. Please look into those too. 
I realise from Stoob's comments not all reports are fixed so undid my close.
Note that if some reports are unfixed when we cut the next rc we should close this against those that are fixed & open a new one/s against remaining reports
I'm curious to know if this is a regression and if so, when did it break. Do you know Stoob?
This is a regression that I think happened some time around 4.7.19?
Coleman Watts I know it's a regression (wasn't this way in 4.6) but sorry wouldn't know for sure in the 4.7.x series when it was introduced. As Jon K Goldberg says this was reported first in 4.7.19 but it could have been a version or two sooner, I don't have any sites available that are pre-4.7.19 to test on at the moment.
I'm closing this as Coleman's PR has been merged which seems to cover a number of reports
I've put in a 2nd PR to fix more of them, but what's really needed is an audit of all reports.
With the merge of PR #11276 should this be closed?
Eileen McNaughton and Coleman Watts Ditto on Andrew's comment. Can this be closed? Are all reports fixed?
I'm happy to assume so - since something is merged against this it's better to close it & add a new issue for any follow ons
This bug doesn't affect me, but I've seen it mentioned multiple times while patrolling Stack Exchange. I think it merits a boost in priority to Important.