Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-20997

Don't send approve mail to user with admin role

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 4.7.0
    • Fix Version/s: 4.7.24
    • Component/s: None
    • Labels:
      None
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      Approval workflow of CiviMail is first introduced and implemented in Civi 3.4. This workflow is driven through Drupal rules. For example, user A creates a mailing and submits . A notification is sent to user B who reviews it and schedules. Then another notification is sent to user C who reviews and approves. Each three user A, B, C must have this mailing permission respectively:

      • Create mailing
      • Schedule mailing
      • Approve mailing

      The issue is that currently the approve mail is sent to all user that have 'approve mailing' permission AND 'administer CiviCRM' permission. So we don't want admins to receive those emails.
      The solution would be to expose those user tokens via the token hook (https://github.com/civicrm/civicrm-core/blob/master/CRM/Utils/Token.php#L1494) . After that one should be able to modify the token values that contain the list of email addresses to whom approve email will be sent. This task may need some code cleanup/refactoring as there are some inconsistencies around token code.

      Redmine - 4029

        Attachments

          Activity

            People

            • Assignee:
              monish.deb Monish Deb
              Reporter:
              monish.deb Monish Deb
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: