Details
Critical
Description
In Event Management under the location tab when logged in with CiviEvent permissions, when you attempt to 'add' another email or phone number a second field is not created. When the 'add' button or 'Add another phone number' link is clicked a JS error is outputted.
ReferenceError: buildAdditionalBlocks is not defined
When you login with administrator privileges the extra email and phone field appear on load. When you try to add a second email or phone number the form only save one of the inputted values (the second inputted value).
Attachments
Issue Links
- links to
Activity
Coleman Watts I think you might need to give input on this (feels like a regression )
I spent about a day following this rabbit down the hole and have not yet reached the bottom. I've done a bunch of form cleanup which is nice and removes some unnecessary spaghetti (and the form now loads faster without the pointless ajax calls) but the underlying problem remains.
https://github.com/civicrm/civicrm-core/pull/11356
I made change in crm/core/bao/block.php, it works
Thanks Panu Boonpromsook - I've added your commit to the existing PR https://github.com/civicrm/civicrm-core/pull/11356
Can someone please test out the PR and verify the fix?
So I've come across another issue that I believe is related to this.
Choose Location form.png
The 'choose location' form linked above is also not appearing for users with 'access CiviEvent' privileges when they try to add or edit events. It DOES appear for anyone with administrator privileges. This is a critical issue because if an event is using an existing location and the user does not see the 'choose location' form they do not know if the location exists on other events. When they do edit the location it will change the location on all the events using that location. Not good.
I've traced this down to an issue with the api call in CRM/Event/BAO/Event.php. On line 1888, there is an api call to get all addresses related to any event.
$result = civicrm_api3('Event', 'get', array( 'check_permissions' => TRUE, 'return' => $ret, 'loc_block_id.address_id' => array('IS NOT NULL' => 1), 'options' => array( 'limit' => 0, ), ));The check_permissions parameter in that api call is set to true. When I set it to false all issues mentioned here appear to be resolved. Both email fields and phone fields appear and you can save values to both fields. Also the choose location form appears for my CiviEvent user.
I've tried altering the check_permissions param using hook_civicrm_alterAPIPermissions with little success. I have managed to alter the param but it has no effect on the result of the api call. Here was the code I used.
function mymodule_civicrm_alterAPIPermissions($entity, $action, &$params, &$permissions) { if ($entity == 'event' && $action == 'get' && preg_match('/^loc_block_id/', $params['return'][0])) { $params['check_permissions'] = false; } }Wondering if we need this permission check for this specific api call?