Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-21148

Refactor "getFromTo()" functions

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 4.7.23
    • Fix Version/s: 5.2
    • Component/s: None
    • Labels:
    • Versioning Impact:
      Patch (backwards-compatible bug fixes)
    • Documentation Required?:
      None
    • Funding Source:
      Contributed Code
    • Verified?:
      No

      Description

      There are two almost identical functions in CiviCRM (surprise!): CRM_Utils_Date::getFromTo() and CRM_Report_Form::getFromTo().

      Ideally, I'd just get rid of the second one and change all the references to point to the first one.  However, multiple well-loved extensions make use of the second function.  So instead I'll just call the first function from the second, and get some test coverage in place.

        Attachments

          Activity

            People

            • Assignee:
              palantejon Jon K Goldberg
              Reporter:
              palantejon Jon K Goldberg
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: