CRM-2145 Unecessary call to CRM_Member_BAO_Membership::getContributionPageId sometimes fails

          Details

          • Type: Patch
          • Status: Done/Fixed
          • Priority: Critical
          • Resolution: Fixed/Completed
          • Affects Version/s: 1.7
          • Fix Version/s: 1.8
          • Component/s: CiviContribute
          • Labels:
            None

            Description

            CRM_Member_BAO_Membership::postProcessMembership makes an unnecessary call to CRM_Member_BAO_Membership::getContributionPageId and occasionally it will fail (not quite sure why, I do notice that the SQL statement in that function is poorly written). The simple solution is to use the value that is already present in $form->_values['id']. Also attached is an error report that describes what happens when the ID lookup fails (you get a completely unrelated error).

              Attachments

                Activity

                [CRM-2145] Unecessary call to CRM_Member_BAO_Membership::getContributionPageId sometimes fails
                Donald A. Lobo added a comment -


                This has already been fixed in the 1.8 code base. I also cleaned up the getContributionPageID function

                Manish Zope added a comment -

                Verify for 2.0

                Manish Zope added a comment -

                Assigning to Rupam for verification

                  People

                  • Assignee:
                    Sunil Pawar
                    Reporter:
                    dave hansen-lange

                    Dates

                    • Created:
                      Updated:
                      Resolved: