Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 2.1
-
Fix Version/s: 2.1.2
-
Component/s: CiviContribute
-
Labels:None
Description
A major problem occurs with presenting billing information on membership contribution pages, in that it doesn't appear on forms in certain circumstances, and in other circumstances, showing missing information in receipt emails:
To recreate:
1. Create a contribution page with a) membership section enabled, b) separate membership and contribution amounts=true, c) allow additional contribution amounts=true
2. Proceed through live form, and do not enter an additional contribution amount.
3. Observe that on the Confirm, Thank you, and email Receipts, the Billing Information, and Credit Card information is not present
4. Repeat above but enter an additional contribution amount, and see that it works correctly.
5. Modify the contribution page so that separate membership and contribution amounts = false.
6. Test the forms and see that the sections are present, but bad information is being sent, e.g. receipt email with 'Billing name = Array'
Note that information is being correctly sent through the payment processor, but it is the parameters used for form presentation are not being set correctly.
Attachments
Activity
When a new membership is created using the On Behalf Of, option, then custom profiles are not passed along correctly to receipt email.
For example, with an 'On Behalf Of' contribution form with a 'Membership information' profile added that includes name and address, the following is included in the email:
===========================================================
===========================================================
first_name : Array
last_name : Array
street_address-Primary : Array
city-Primary : Array
state_province-Primary : Array
postal_code-Primary : Array
country-Primary : Array
phone-Primary : Array
For contributions with just personal memberships, the profile section shows correctly:
===========================================================
Membership information
===========================================================
First Name : Test
Last Name : Testt
Address : 123
City : sdaf
Province / State : BC
Postal / Zip Code : sdff
Country : Canada
Email : testt@test.test
Phone : 23we
fixed in r17835
Checked with r18157.
tested in r18872
Starting to work through this myself. First change to email template to cause billing section to show if just a membership is being purchased:
CRM/Contribute/Form/Contribution/ReceiptMessage.tpl, Line 93
+
{elseif $amount OR $membership_amount}I haven't tested all circumstances, so would have to make sure still it doesn't cause billing to appear in other unwanted cases.
For the Contribution/Confirm.tpl and Contribution/Thankyou.tpl, the line here is the one that fails to return true:
{if $contributeMode ne 'notify' and ! $is_pay_later and $is_monetary and $amount GT 0 }One possible solution would be to add membership_amount to template variables, then change to
{if $contributeMode ne 'notify' and ! $is_pay_later and $is_monetary and ($amount GT 0 OR $membership_amount GT 0)}