Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-4143

Tell a Friend - (via somedomain.org) value appended to FROM email address should be derived from CiviCRM site domain

    Details

    • Type: Bug
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 2.1.4
    • Fix Version/s: 2.2.0
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      When sending mail via Tell a Friend feature, the From: email address is constructed incorrectly.

      I donated as jack.adams@creepy.org and then sent a Tell a Friend mail.

      The output was:
      From: "jack.adams@creepy.org (via creepy.org)" <jack.adams@creepy.org>

      The intended behavior is to use the domain part of the configured default FROM email address (which I had set to "info@civicrm.org"). The point of having the "via" is to clarify that the email was sent out from the owning org's site and not directly from "my friend".

      From my snooping, the code which apparently sets the "via" currently is in Friend/BAO/Friend.php (line 192).

      list( $username, $mailParams['domain'] ) = split( '@', $mailParams['email_from'] );

        Attachments

          Activity

            People

            • Assignee:
              sunil Sunil Pawar
              Reporter:
              dgg David Greenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 15 minutes
                15m
                Remaining:
                Remaining Estimate - 15 minutes
                15m
                Logged:
                Time Spent - Not Specified
                Not Specified