Details
Minor
Description
On event dashboard we should show following:
Counted (clickable link) = participant with counted status + counted role
Not Counted = participant with not counted status or not counted role
Not Counted Due to Status (clickable link) = participant with not counted status
Not Counted Due to Role (clickable link) = participant with not counted role
– Original Post --------------------------------------------------
Patch included as a follow up on this issue
http://forum.civicrm.org/index.php/topic,9341.0.html
Note that I switched to the 'filler' field to leverage code for another option and that this field needs to be updated to a value of '1' for all existing roles to make them 'counted'
I kept the dashboard update pretty rudimentary - i.e I added a 'Other Roles' count and removed uncounted roles from the other aggregates.
Attachments
Activity
Hi,
I just checked this and I think there was some problem with the way I used the pseudoconstant in participant.php. I think this version of CRM/Event/BAO/Participant.php is what I changed it to. (below).
However, I also hit one more thing when I was working with this - it changes whether the registrations already created are counted or not but you can't add another 'uncounted' registration. ie. if you have 9 attendees (counted) and 5 volunteers (not counted) in an event and the limit is (11 counted ) you can add another 5 volunteers but once you hit 10 attendees you can't add any more volunteers as the event is defined as full before you can tell it the role you are trying to register.
I was actually trying to set the role using a hook from the url / or through the registration form and I couldn't seem to set the role prior to being kicked out
function approx line 281
static function eventFull( $eventId, $isDeference = false, $role = null )
{
require_once 'CRM/Event/PseudoConstant.php';
$statusTypes = CRM_Event_PseudoConstant::participantStatus( null, "filter = 1" );
require_once "CRM/Core/OptionGroup.php";
$countedRoles = implode(',', CRM_Core_OptionGroup::values("participant_role",false,false,false,"AND filter = 1","value" ));
$notCountedRoles = CRM_Core_OptionGroup::values("participant_role",false,false,false,"AND filter = !1","value" );
if (in_array( $role , $notCountedRoles ))
{ return false; } $status = implode( ',', array_keys( $statusTypes ) );
if ( !$status )
// fix for CRM-2877, participant has to have is_filter true
// for event to be full
assigning for 3.1 verification
We need to discuss this. It looks completely broken to me and I'm not sure what it will take to fix. Let's discuss....
1. Look at default CiviEvent dashboard w/ sample data (http://sandbox.civicrm.org/civicrm/event&reset=1). Role Counted and Role Not Counted counts are equal for all 3 events (partially because default 'Roles' data doesn't have 'Counted' set for any role). If you click these links you get a different count in Find Participants than what is displayed in dashboard.
2. I updated my local sandbox to set Counted = true for 'Attendee' role. This corrected the 'Role Counted' / 'Role Not Counted' dashboard counts but broke other counts.
I think there's a problem in that we have two dimensions of determining counted vs. not-counted - Status vs. Role - and the code is not blending them properly. If they were blended properly, than the dashboard display should NOT have 2 different types of "Counted / Not Counted" - since that property for a given participant must be an 'AND' on status + role.
I did not test the max participants limits with role counting enabled, but suspect it's also broken.
If we deliver 3.1 with this feature included, we would at minimum need to set realistic defaults for Role counted - e.g. Attendee = counted, others = not counted. Not sure what correct behavior should be if NO ROLES have counted = true ?? Maybe this disables the feature?
checked in r25732
verified in r28660.
checked in rev 24525