Details
-
Type:
Bug
-
Status: Done/Fixed
-
Priority:
Major
-
Resolution: Fixed/Completed
-
Affects Version/s: 3.0, 3.0.1, 3.0.2
-
Fix Version/s: Unscheduled
-
Component/s: Core CiviCRM
-
Labels:None
Description
In the Drupal version of CiviCRM 3.0+, on all the CiviCRM pages (pages with paths beginning "civicrm/"), PHP throws a "missing argument 1 for civicrm_help" error.
When I looked at the code of civicrm/drupal/civicrm.module, I saw that civicrm_help had the old function signature from 5.x - civicrm_help($section). I updated that to the 6.x syntax - civicrm_help($path, $arg). However, it still doesn't work. For now, I have had to comment out the civicrm_help function entirely to prevent this error from occurring.
I am not sure why hook_help() is not receiving the page arguments properly, unless somehow they are being "eaten" by civicrm_initialize().
Attachments
Activity
I tested it in Garland, and the error didn't show up. However, it shows up in several different themes that we have created, not just one. Our themes were based off of a theme called Basic, and we have the Admin module enabled. I don't know what in particular would cause this error.
Note that the function signature for civicrm_help should be updated to civicrm_help($path, $arg) even if the current function signature is not the cause of the error.
Thanks for your help - since we want to see CiviCRM in our site's theme, I will simply comment out civicrm_help for now.
Since it appears that this issue is specific to certain themes, feel free to mark its priority down from Major to what you feel is more appropriate.
deepak: do u remember what we did to fix this for sfschool?
Closing as of 4.0.7, European Code Sprint 12/2011.
most likely this is a theme issue. can you see if you get the same error when u switch to the default garland theme?
i got this on the sfschool site, but dont remember how we worked around it