Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-5554

Civicrm should check for a false return value on calling setlocale()

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.0.3
    • Fix Version/s: 3.0.4
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      When civicrm calls setlocale() in Variables.php, it does not check for a return value of false. This means that either the php install does not have gettext installed or none of the locales are available and should cause an error to warn the user.

      I have attached a patch against 3.0.3 to add a check for setlocale() returning false and throw a fatal error. (This is actually my first time submitting a patch, so hopefully I got the format right

      Jordan

        Attachments

          Activity

            People

            • Assignee:
              shot Piotr Szotkowski
              Reporter:
              jords Jordan Thoms
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: