CRM-5658 Implement improved float clearing method

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.1
    • Fix Version/s: 4.3.0
    • Component/s: CiviContribute, CiviEvent
    • Labels:
      None

      Description

      The 'clear' patch attached to this issue represents a possibly cleaner way to clear floats in our new front-end markup (eliminates using the extra <div class="clear></div> markup).

        Attachments

          Activity

          [CRM-5658] Implement improved float clearing method
          David Greenberg added a comment -

          I'm working on some other layout fixes in Confirm.tpl and Thankyou.tpl. Will check on this a incorporate as needed (for some reason the billing name was duplicated in the latest commit on those files). Also, on a related note, the recent patches used markup shortcut that doesn't work properly (at least in firefox):

          <div class="clear" />

          Firefox doesn't seem to see this div as closed and so the containing section doesn't get the margin-bottom style applied. I'm changing all these to use:

          <div class="clear></div>

          Matt Moen added a comment -

          I was going to work on a patch to remove all of these clear divs and replace them with a clear-block implementation, which is a lot cleaner, works in all browsers and doesn't require empty elements ... probably won't have it before tomorrow tho

          David Greenberg added a comment -

          Matt - If you can quickly post a replacement example for 'clear-block' implementation - we can look at it and potentially implement on our side.

          Matt Moen added a comment -

          Attached patch implements clear-block for all the already re-worked templates. A new css class, crm-clear-block, is based on the drupal clear-block style, which in turn is based on easy clearing:
          http://www.positioniseverything.net/easyclearing.html

          This allows you to apply a class to a container which effectively tells that container to contain all floats without additional markup. Untested but the patch should apply to trunk

          David Greenberg added a comment -

          Pushing this to 3.2 since if we use this approach we would want to use it in all places.

          David Greenberg added a comment -

          CRM-5623 commits should have fixed the original 'extraneous empty billing name' issue.

          Donald A. Lobo added a comment -

          These 448 issues have not been worked on for the past 18 months.

          Doing a bulk close of old issues to make the issue queue more manageable. We should do this on a periodic basis.

            People

            • Assignee:
              kyle jaster
              Reporter:
              Matt Moen

              Dates

              • Created:
                Updated:
                Resolved: