CRM-6039 ContributionProcessor.php does not populate first_name and last_name for Google Checkout

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.2
    • Component/s: CiviContribute
    • Labels:
      None

      Description

      ContributionProcessor.php leverages CRM/Contribute/BAO/Contribution/Utils.php::formatAPIParams() to map incoming fields to local CiviCRM fields. Currently the code does not populate the first_name and last_names fields, which is somewhat important. By default Google Checkout notifications don't include first and last name elements, but only a single concatenated name. However, it is possible to turn on a feature via the integration settings at Google Checkout that will cause Google to emit first and last name fields in the notifications. However, formatAPIParams() uses a section of the notifications ([risk-information-notification]) to obtain user data that will never contain the first and last name fields. The attached patches should fix this issue. They are for:

      CRM/Contribute/BAO/Contribution/Utils.php
      bin/ContributionProcessor.php

      For reference see this forum thread:

      http://forum.civicrm.org/index.php?topic=12987

      Though I stumbled across this issue with contributions pulled in via ContributionProcessor.php, presumably this affects all Google Checkout contributions.

      Nathan

        Attachments

        1. ContributionProcessor.php.patch
          0.7 kB
          Nathan Kinkade
        2. Utils.php.patch
          3 kB
          Nathan Kinkade

          Activity

          [CRM-6039] ContributionProcessor.php does not populate first_name and last_name for Google Checkout
          Rahul Bile added a comment -

          checked in r-27838.

            People

            • Assignee:
              Rahul Bile
              Reporter:
              Nathan Kinkade

              Dates

              • Created:
                Updated:
                Resolved: