CRM-6948 Opt-Out link in email not generated clean in a Drupal site so configured

please discuss on forums. this is a permisisoning issue

How is an unclean generated url a permissioning issue?

I have just enabled "access CiviMail subscribe/unsubscribe pages" for anonymous users. It does seem unproductive to have that as a permissioned item in CiviCRM, since the only way to reach it would be via an opt-out link sent by CiviCRM. Or, perhaps I am misunderstanding that particular permission.

we should find and fix the non clean-url issue

I tried hard to replicate this, but can't; in my setup the opt-out and unsubscribe URLs are generated properly (i.e., they're 'clean' URLs). Is there a simple way to reproduce it?

Pushing to 3.3.beta for now

james:

what version are u running?

In 3.2 we bootstrap drupal and hence know if clean urls are enabled or not. In 3.1 and prior we did not have this info and hence all urls were generated in the regular format, i.e. unclean

Suspect this was fixed in 3.2 when we started bootstrapping drupal

re-opening for Tim as he CAn reproduce

The cleanurl behavior is detected in civicrm.settings.php with this test:

------------
if ( function_exists( 'variable_get' ) && variable_get('clean_url', '0') != '0' ) {
define( 'CIVICRM_CLEANURL', 1 );
} else {
define( 'CIVICRM_CLEANURL', 0 );
}
------------

The test works correctly in the normal case where Drupal bootstraps before CiviCRM (i.e. Drupal... -> civicrm_initialize... -> require civicrm.settings.php). However, when CiviCRM bootstraps before Drupal, the 'variable_get' function is undefined at the critical moment, so the test determines that cleanurl is unavailable. This most likely causes failures in all cron scripts.

There is probably some clean solution which involves moving the test logic from civicrm.settings.php to some part of CRM/Utils/System/Drupal.php where the availability of variable_get can be assured. It's not obvious to me where that is. In lieu of that, the attached patch adds an extra instruction to loadBootstrap which refreshes cleanURL.

Aside: This bug would not be reproduced when using, say, CiviMail's "Preview" feature (or "Send test mailing" – but I didn't test) because that uses the standard Drupal->CiviCRM bootstrapping. To reproduce, one must actually invoke the cron script in the documented fashion.