CRM-6959 EmailProcessor - ambiguity about bounce + activity processing usage

    Details

    • Type: Improvement
    • Status: Done/Fixed
    • Priority: Major
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.2.3
    • Fix Version/s: 3.3.beta
    • Component/s: CiviMail
    • Labels:
      None

      Description

      EmailProcessor.php script serves two purposes – bounce processing and email-to-activity processing. In the current structure, placing "&emailtoactivity=1" in the url triggers the latter. Absent that url variable, the script processes mailboxes as bounces. There are several problems with the current structure:

      • you cannot call the script to perform both actions at once – if the &emailtoactivity=1 is present, it does not processes bounces, and absent, it does not process actvities
      • if you choose to process as activities, yet are using one of the accounts to collect bounces, the bounces are processed as activities
      • the admin interface has the option of selecting a default account, but it is unclear what that does

      The attached patches offer an incremental improvement. More could be done. It does the following:

      • alters the admin interface so we ask how the account will be used for. this does not alter the schema – the is_default field is used, and a value of 1 = bounce processing (should be most backwards compatible with existing usage). this also assume standard is_default behavior, where only one option can be selected as the default.
      • alters the EmailProcessor.php script to reflect these explicit usage selections

      Further suggested improvements:

      • enable the ability to select a mailbox as used for both bounce and activity processing. this would involve some changes to make sure a single email is not processed for both functions, and we would probably need a new field in the civicrm_mail_settings table, as is_default is also used to determine the envelope email for sending mailings. so additional additional value options could be problematic.
      • create additional options for activity processing (should contacts be created, or only match to existing, etc.)

        Attachments

        1. bin_EmailProcessor.php.patch
          2 kB
          Brian Shaughnessy
        2. bin_EmailProcessor.php.patch
          2 kB
          Brian Shaughnessy
        3. CRM_Admin_Form_MailSettings.php.patch
          0.4 kB
          Brian Shaughnessy
        4. templates_CRM_Admin_Form_MailSettings.tpl.patch
          0.8 kB
          Brian Shaughnessy
        5. templates_CRM_Admin_Page_MailSettings.tpl.patch
          1.0 kB
          Brian Shaughnessy

          Activity

          [CRM-6959] EmailProcessor - ambiguity about bounce + activity processing usage
          Brian Shaughnessy added a comment -

          table listing improvements

          Donald A. Lobo added a comment -

          I've patched 3.3 with the above patches.

          However, i dont think bin/EmailProcessor.php is backward compatible. Would be good to still allow the GET arguments to override the settings in the UI since it seems fairly easy to do

          brian: can u submit a patch to fix this

          Brian Shaughnessy added a comment -

          adjustments to better preserve backwards compatibility when emailtoactivity is specified in the url

            People

            • Assignee:
              Donald A. Lobo
              Reporter:
              Brian Shaughnessy

              Dates

              • Created:
                Updated:
                Resolved: