Uploaded image for project: 'CiviCRM'
  1. CiviCRM
  2. CRM-6990

in Drupal admin menu, onclick handler for 'CiviCRM' item wrongly attaches to other items

    Details

    • Type: Patch
    • Status: Done/Fixed
    • Priority: Trivial
    • Resolution: Fixed/Completed
    • Affects Version/s: 3.1.3, 3.1.4, 3.1.5, 3.1.6, 3.2, 3.2.1, 3.2.2, 3.2.3
    • Fix Version/s: 3.3.alpha
    • Component/s: Core CiviCRM
    • Labels:
      None

      Description

      Based on forum thread here: http://forum.civicrm.org/index.php/topic,16252.msg69457.html

      CiviCRM attaches an onClick handler to any item in the Drupal admin menu that contains the text "CiviCRM", so as to allow the "CiviCRM" menu item to display the CiviCRM navigation menu.

      Problem behavior: this onClick handler also attaches to any item in the menu that contains "CiviCRM" anywhere, and this includes items named, for example, "foo CiviCRM bar", plus any of their parent items, since the parent items are also containers of that text.

      Example: the "CiviCRM congressional district" module ads a menu item labeled "CiviCRM congressional district" under "Site configuration," thus rendering the whole "Site configuration" menu un-clickable.

      A comment in the code says, "Need to fix this properly." Not sure if it applies to this issue or not, so did not remove that comment.

      (Thanks to Xavier for improving the patch.)

        Attachments

        1. Navigation.patch
          0.9 kB
          Allen Shaw
        2. Navigation.patch
          0.9 kB
          Allen Shaw

          Activity

            People

            • Assignee:
              kurund Kurund Jalmi
              Reporter:
              allenshaw Allen Shaw
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: